linux-kernel - Re: [PATCH] regulator: tps6586x - add regulator_unregister() in tps6586x_regulator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4C6170FB.9080609@compulab.co.il>
Date:	Tue, 10 Aug 2010 18:32:11 +0300
From:	Mike Rapoport <mike@...pulab.co.il>
To:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
CC:	Axel Lin <axel.lin@...il.com>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	Liam Girdwood <lrg@...mlogic.co.uk>
Subject: Re: [PATCH] regulator: tps6586x - add regulator_unregister() in tps6586x_regulator_remove()

Mark Brown wrote:
> On Mon, Aug 09, 2010 at 03:58:06PM +0800, Axel Lin wrote:
>> Signed-off-by: Axel Lin <axel.lin@...il.com>
> 
> Acked-by: Mark Brown <broonie@...nsource.wolfsonmicro.com>

Acked-by: Mike Rapoport <mike@...pulab.co.il>

> 
>>  
>> -	platform_set_drvdata(pdev, ri);
>> +	platform_set_drvdata(pdev, rdev);
>>  
> 
> This would've been easier to review if you'd mentioned in the changelog
> that there were no users of the current platform data, just to show that
> you'd checked.


-- 
Sincerely yours,
Mike.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/