linux-kernel - Re: [REVISED PULL REQUEST] md updates for 2.6.36

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTinbCHAB3tPos1sp078maWaHAQbRM8oWMOiF1U8D@mail.gmail.com>
Date:	Tue, 10 Aug 2010 15:47:21 -0700
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Neil Brown <neilb@...e.de>
Cc:	linux-raid@...r.kernel.org, linux-kernel@...r.kernel.org,
	dm-devel@...hat.com, David Woodhouse <dwmw2@...radead.org>
Subject: Re: [REVISED PULL REQUEST] md updates for 2.6.36

On Mon, Aug 9, 2010 at 5:14 PM, Neil Brown <neilb@...e.de> wrote:
>
>  create mode 100644 lib/raid6/Makefile
>  rename {drivers/md => lib/raid6}/mktables.c (100%)
>  rename {drivers/md => lib/raid6}/raid6algos.c (100%)
>  rename {drivers/md => lib/raid6}/raid6altivec.uc (100%)
>  rename {drivers/md => lib/raid6}/raid6int.uc (100%)
>  rename {drivers/md => lib/raid6}/raid6mmx.c (100%)
>  rename {drivers/md => lib/raid6}/raid6recov.c (100%)
>  rename {drivers/md => lib/raid6}/raid6sse1.c (100%)
>  rename {drivers/md => lib/raid6}/raid6sse2.c (100%)
>  rename {drivers/md => lib/raid6}/raid6test/Makefile (100%)
>  rename {drivers/md => lib/raid6}/raid6test/test.c (100%)
>  rename {drivers/md => lib/raid6}/raid6x86.h (100%)
>  rename {drivers/md => lib/raid6}/unroll.awk (100%)

Hmm. Why "lib/raid6/raid6sse2.c" and friends? Why "raid6" twice? You
don't mean "raid6+1" (mirrored raid6 ;), so why not just remove the
second "raid6", and call it "lib/raid6/sse2.c"

But I pulled. Just in case there was some logic to the duplication.

                               Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/