linux-kernel - Re: [rtc-linux] [PATCH 1/2] rtc: rtc-lpc32xx: Introduce RTC driver for the LPC32XX SoC

Open Source and information security mailing list archives

Message-ID: <AANLkTinZBhZ8PRswbqUDyYzmDQ6Ccm96QAO8vpeWn+SD@mail.gmail.com>
Date:	Wed, 11 Aug 2010 09:40:55 +0800
From:	Wan ZongShun <mcuos.com@...il.com>
To:	Kevin Wells <kevin.wells@....com>
Cc:	"rtc-linux@...glegroups.com" <rtc-linux@...glegroups.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Durgesh Pattamatta <durgesh.pattamatta@....com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	Kevin Wells <wellsk40@...il.com>
Subject: Re: [rtc-linux] [PATCH 1/2] rtc: rtc-lpc32xx: Introduce RTC driver 
	for the LPC32XX SoC

2010/8/11 Kevin Wells <kevin.wells@....com>:
> Hi Zongshun,
>
> Thanks for helping review this.
>
>> Subject: Re: [rtc-linux] [PATCH 1/2] rtc: rtc-lpc32xx: Introduce RTC driver
>> for the LPC32XX SoC
>>
>> Hi Kevin ,
>>
>> This is really a natty rtc patch:).
>
> From the urban dictionary...
> "natty"
> 1) originating from rastafarian culture. meaning 'good','cool' and
> most importantly, 'elite'.
> 2) A slang for Natural Light beer, a favorite of poor college students
> the world over.
>

Hmm,I means the first, this patch looks very good to me. :)

> I hope it's the first one, but I guess the 2nd isn't that bad if
> you’re a college student o)
> I'll merge both patches into a single patch for v2 and repost in a
> few days.
>
>> > +       /* Disable alarm during update */
>> > +       tmp = rtc_readl(rtc, RTC_CTRL);
>> > +       rtc_writel(rtc, RTC_CTRL, tmp & ~RTC_MATCH0_EN);
>> > +
>> > +       rtc->alarm_enabled = wkalrm->enabled = 1;
>> > +       if (wkalrm->enabled) {
>> > +               rtc_writel(rtc, RTC_MATCH0, alarmsecs);
>> > +               rtc_writel(rtc, RTC_INTSTAT, RTC_MATCH0_INT_STS);
>> > +               rtc_writel(rtc, RTC_CTRL, tmp | RTC_MATCH0_EN);
>> > +       }
>>
>> I think this 'wkalrm->enabled ' will always be set '1', so 'if'
>> condition will be alway true?
>
> Thanks for catching this. The '= 1' assignment shouldn't be there.
>

-- 
*linux-arm-kernel mailing list
mail addr:linux-arm-kernel@...ts.infradead.org
you can subscribe by:
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

* linux-arm-NUC900 mailing list
mail addr:NUC900@...glegroups.com
main web: https://groups.google.com/group/NUC900
you can subscribe it by sending me mail:
mcuos.com@...il.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives