linux-kernel - RE: [PATCH 1/4] initial support for LogicPD's OMAP3 SOM and TORPEDO development kits

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <77A0A4DB5BF2A44283E5522C27234AC6021C82D7@EDPRSRV011.logicpd.com>
Date:	Wed, 11 Aug 2010 13:53:52 -0500
From:	"Jacob Tanenbaum" <Jacob.Tanenbaum@...icpd.com>
To:	"Kevin Hilman" <khilman@...prootsystems.com>
Cc:	<linux@....linux.org.uk>, <linux-omap@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <rmk@....linux.org.uk>,
	<tony@...mide.com>
Subject: RE: [PATCH 1/4] initial support for LogicPD's OMAP3 SOM and TORPEDO development kits



-----Original Message-----
From: Kevin Hilman [mailto:khilman@...prootsystems.com] 
Sent: Wednesday, August 11, 2010 2:05 PM
To: Jacob Tanenbaum
Cc: linux@....linux.org.uk; linux-omap@...r.kernel.org;
linux-kernel@...r.kernel.org; rmk@....linux.org.uk; tony@...mide.com
Subject: Re: [PATCH 1/4] initial support for LogicPD's OMAP3 SOM and
TORPEDO development kits

Jacob Tanenbaum <Jacob.Tanenbaum@...icpd.com> writes:

> 	Adding LogicPD OMAP3 board support
>
>          Adding support for LogicPD's OMAP 3530 LV SOM and
>          OMAP 35x Torpedo board.
> 	 
> 	 Tested against: linux-next
81e09f50c93edff607259cbe374a3006c9c5fa74
>          Signed-off-by: Jacob Tanenbaum <Jacob.Tanenbaum@...icpd.com>

[...]

> +/* Micron MT46H32M32LF-6 */
> +/* FIXME: borrowed from sdram-micron-mt46h32m32lf-6.h because on
LogicPD
> + * boards we can't use the default values -- why? I suspect the
reason
> + * lies in the boot strap code. We correct this part if we have
ported
> + * U-Boot and X-Load. */

Another option here instead of re-defining the struct is to includ the
original header and just change the values you need to.  That way
you can describe the reasons behind the values that are changing.

Will fix

[...]

> +static struct omap_board_config_kernel omap3logic_config[] __initdata
= {
> +};
> +
> +static void __init omap3logic_init_irq(void)
> +{
> +	omap_board_config = omap3logic_config;
> +	omap_board_config_size = ARRAY_SIZE(omap3logic_config);
> +	omap2_init_common_hw(mt46h32m32lf6_sdrc_params,
> +				mt46h32m32lf6_sdrc_params);
> +	omap_init_irq();
> +#ifdef CONFIG_OMAP_32K_TIMER
> +	omap2_gp_clockevent_set_gptimer(12);
> +#endif

Why do you need GPT12?

Was this a copy-paste from Beagle?  Certain revs of beagle had this
limitation due to a board design problem, so unless you've inherited the
same board-design problem, you should be find with the default.

Will test and fix


Kevin
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/