lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 11 Aug 2010 11:06:00 +0900 From: FUJITA Tomonori <fujita.tomonori@....ntt.co.jp> To: khc@...waw.pl Cc: fujita.tomonori@....ntt.co.jp, linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org Subject: Re: ARM: 2.6.3[45] PCI regression (IXP4xx and PXA?) On Tue, 10 Aug 2010 22:36:21 +0200 Krzysztof Halasa <khc@...waw.pl> wrote: > 6fee48cd330c68332f9712bc968d934a1a84a32a broke > pci_set_consistent_dma_mask() on IXP4xx and most probably PXA. Affected > devices are e.g. IDE controller (CS5536-based: disk inaccessible) and > e1000 ethernet ("Detected Tx Unit Hang"). Sorry about that. > The attached patch makes it work again, though I'm not sure it's the > best solution. I think that we should avoid adding "#ifdef CONFIG_DMABOUNCE" to a generic place. Why the above patch breaks dmabounce.c? We can't set dev->coherent_dma_mask? > diff --git a/include/linux/dma-mapping.h b/include/linux/dma-mapping.h > index ca32ed7..bd2a7d3 100644 > --- a/include/linux/dma-mapping.h > +++ b/include/linux/dma-mapping.h > @@ -129,6 +129,14 @@ static inline u64 dma_get_mask(struct device *dev) > > static inline int dma_set_coherent_mask(struct device *dev, u64 mask) > { > +#ifdef CONFIG_DMABOUNCE > + if (dev->archdata.dmabounce) { > + if (mask >= ISA_DMA_THRESHOLD) > + return 0; > + else > + return -EIO; > + } > +#endif > if (!dma_supported(dev, mask)) > return -EIO; > dev->coherent_dma_mask = mask; > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@...r.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists