linux-kernel - Re: remove inode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100810175944.5919319e.akpm@linux-foundation.org>
Date:	Tue, 10 Aug 2010 17:59:44 -0700
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Al Viro <viro@...IV.linux.org.uk>
Cc:	Stephen Rothwell <sfr@...b.auug.org.au>,
	Christoph Hellwig <hch@....de>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Eric Van Hensbergen <ericvh@...il.com>,
	Sripathi Kodi <sripathik@...ibm.com>,
	LKML <linux-kernel@...r.kernel.org>, linux-next@...r.kernel.org
Subject: Re: remove inode_setattr

On Wed, 11 Aug 2010 01:52:16 +0100
Al Viro <viro@...IV.linux.org.uk> wrote:

> Whiskey Tango Fotrot, Over
> 
> In Linus' tree we have
> commit 1025774ce411f2bd4b059ad7b53f0003569b74fa
> Author: Christoph Hellwig <hch@....de>
> Date:   Fri Jun 4 11:30:02 2010 +0200
> ...
> diff --git a/fs/9p/vfs_inode.c b/fs/9p/vfs_inode.c
> index 4331b3b..4b3ad6a 100644
> --- a/fs/9p/vfs_inode.c
> +++ b/fs/9p/vfs_inode.c
> @@ -896,10 +896,19 @@ static int v9fs_vfs_setattr(struct dentry *dentry, struct 
>         }
>  
>         retval = p9_client_wstat(fid, &wstat);
> -       if (retval >= 0)
> -               retval = inode_setattr(dentry->d_inode, iattr);
> +       if (retval < 0)
> +               return retval;
> +
> +       if ((iattr->ia_valid & ATTR_SIZE) &&
> +           iattr->ia_size != i_size_read(dentry->d_inode)) {
> +               retval = vmtruncate(dentry->d_inode, iattr->ia_size);
> +               if (retval)
> +                       return retval;
> +       }
> 
> So what the hell is going on?

That's v9fs_vfs_setattr().  The problem is in the new
v9fs_vfs_setattr_dotl().

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/