linux-kernel - Re: [MeeGo-Dev][PATCH] Topcliff: Update PCH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <000601cb391e$afec6b60$66f8800a@maildom.okisemi.com>
Date:	Wed, 11 Aug 2010 15:30:20 +0900
From:	"Masayuki Ohtake" <masa-korg@....okisemi.com>
To:	"Greg KH" <gregkh@...e.de>
Cc:	"Wang, Qi" <qi.wang@...el.com>, <meego-dev@...go.com>,
	"LKML" <linux-kernel@...r.kernel.org>,
	"Wang, Yong Y" <yong.y.wang@...el.com>,
	"Khor, Andrew Chih Howe" <andrew.chih.howe.khor@...el.com>,
	<arjan@...ux.intel.com>
Subject: Re: [MeeGo-Dev][PATCH] Topcliff: Update PCH_IEEE1588 driver to 2.6.35

Hi Greg,

> Use the 'bool' type, and 'true' and/or 'false' keywords instead.  That
> is the proper C idiom.
I can do well.

Thanks, Ohtake.

----- Original Message ----- 
From: "Greg KH" <gregkh@...e.de>
To: "Masayuki Ohtake" <masa-korg@....okisemi.com>
Cc: "Wang, Qi" <qi.wang@...el.com>; <meego-dev@...go.com>; "LKML" <linux-kernel@...r.kernel.org>; "Wang, Yong Y"
<yong.y.wang@...el.com>; "Khor, Andrew Chih Howe" <andrew.chih.howe.khor@...el.com>; <arjan@...ux.intel.com>
Sent: Wednesday, August 11, 2010 1:39 PM
Subject: Re: [MeeGo-Dev][PATCH] Topcliff: Update PCH_IEEE1588 driver to 2.6.35


> On Wed, Aug 11, 2010 at 01:34:33PM +0900, Masayuki Ohtake wrote:
> > Hi Qi-san
> >
> > I have found Macro 'TRUE' and 'FALSE' are used as setting value in the driver; still,
> > can't I use TRUE/FALSE macro ?
> > If not, How should we implement ?
>
> Use the 'bool' type, and 'true' and/or 'false' keywords instead.  That
> is the proper C idiom.
>
> thanks,
>
> greg k-h
>


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/