[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <201008120443.24749.marek.vasut@gmail.com>
Date: Thu, 12 Aug 2010 04:43:24 +0200
From: Marek Vasut <marek.vasut@...il.com>
To: David Woodhouse <dwmw2@...radead.org>
Cc: "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>,
"linux@....linux.org.uk" <linux@....linux.org.uk>,
"nico@...xnic.net" <nico@...xnic.net>,
"kernel@...tstofly.org" <kernel@...tstofly.org>,
"kernel@...gutronix.de" <kernel@...gutronix.de>,
"u.kleine-koenig@...gutronix.de" <u.kleine-koenig@...gutronix.de>,
"kaloz@...nwrt.org" <kaloz@...nwrt.org>,
"khc@...waw.pl" <khc@...waw.pl>, "tj@...nel.org" <tj@...nel.org>,
"gregkh@...e.de" <gregkh@...e.de>,
"stable-review@...nel.org" <stable-review@...nel.org>,
"torvalds@...ux-foundation.org" <torvalds@...ux-foundation.org>,
"akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
"alan@...rguk.ukuu.org.uk" <alan@...rguk.ukuu.org.uk>,
"Artem.Bityutskiy@...ia.com" <Artem.Bityutskiy@...ia.com>
Subject: Re: [PATCH] ARM: Fix gen_nand probe structures contents
Dne Čt 12. srpna 2010 03:21:52 David Woodhouse napsal(a):
> On Thu, 2010-08-12 at 02:14 +0100, Marek Vasut wrote:
> > These three platforms didn't properly fill nr_chips in gen_nand
> > registration and
> > therefore depended on gen_nand bug fixed by the following patch:
> >
> > "mtd: gen_nand: fix support for multiple chips"
> >
> > Signed-off-by: Marek Vasut <marek.vasut@...il.com>
>
> Thanks. I've applied that to the mtd-2.6.git tree, which has a few
> straggling commits I'll be asking Linus to pull shortly.
>
> In case there are any more, would you care to complement it with a check
> in the driver that detects the nonsensical case of nr_chips == 0,
> assumes it means 1, and also warns about it?
I checked whole arch-arm and there are no more. nr_chips check would be a nice
thing, I was thinking of it already when I sent the first patch. I just checked
the other archs and there are more breaks. I'll implement the check in a
separate patch.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists