linux-kernel - Re: linux-next: build failure after merge of the cifs tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100812174621.b1dbc20f.sfr@canb.auug.org.au>
Date:	Thu, 12 Aug 2010 17:46:21 +1000
From:	Stephen Rothwell <sfr@...b.auug.org.au>
To:	Steve French <smfrench@...il.com>
Cc:	linux-cifs@...r.kernel.org, linux-next@...r.kernel.org,
	linux-kernel@...r.kernel.org, Wang Lei <wang840925@...il.com>,
	Bryan Schumaker <bjschuma@...app.com>,
	David Howells <dhowells@...hat.com>
Subject: Re: linux-next: build failure after merge of the cifs tree

Hi Steve,

On Wed, 11 Aug 2010 23:04:36 -0500 Steve French <smfrench@...il.com> wrote:
>
> Are you sure that this is a valid config file?  CONFIG_KEYS should be
> set if CONFIG_DNS_RESOLVER is set?

It is a ppc64_defconfig.  It has:

# CONFIG_KEYS is not set
CONFIG_DNS_RESOLVER=y

CONFIG_NFS_USE_KERNEL_DNS just selects CONFIG_DNS_RESOLVER but there is
no dependency on CONFIG_KEYS (select does not care about the
dependencies of the selected config option).

> key.h looks like it is included in all arch in this path
> 
> net/dns_resolver/dns_key.c includes
> include/keys/dns_resolver-type.h which includes
> include/linux/key-type.h which includes
> include/linux/key.h
> 
> the line 258 "key_instantiate_and_link" error could occur if
> "CONFIG_KEYS" is not set in .config

Which t isn't.

> net/dns_resolver/Kconfig config DNS_RESOLVER "depends on NET && KEYS"
> so ... CONFIG_KEYS should be set ....

See above.  You need CONFIG_NFS_USE_KERNEL_DNS to also depend on
CONFIG_KEYS ...

-- 
Cheers,
Stephen Rothwell                    sfr@...b.auug.org.au
http://www.canb.auug.org.au/~sfr/

Content of type "application/pgp-signature" skipped