linux-kernel - Re: [PATCH v2] MD: raid, fix BUG caused by flags handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <x49mxss3qt5.fsf@segfault.boston.devel.redhat.com>
Date:	Thu, 12 Aug 2010 09:26:30 -0400
From:	Jeff Moyer <jmoyer@...hat.com>
To:	Jiri Slaby <jslaby@...e.cz>
Cc:	akpm@...ux-foundation.org, linux-raid@...r.kernel.org,
	linux-scsi@...r.kernel.org, jirislaby@...il.com,
	linux-kernel@...r.kernel.org, Christoph Hellwig <hch@....de>,
	Neil Brown <neilb@...e.de>
Subject: Re: [PATCH v2] MD: raid, fix BUG caused by flags handling

Jiri Slaby <jslaby@...e.cz> writes:

> Commit 74450be1 (block: unify flags for struct bio and struct request)
> added direct test of flags in the & form:
>   const bool do_sync = (bio->bi_rw & REQ_SYNC);
> But this doesn't fit into bool with my compiler (gcc 4.5). So change
> the type to ulong to avoid the bug.

At first I wondered why you didn't use the !! trick, but after looking
at the code, I see that the result is |'d into bi_rw.

Looks good.  Sounds like it might have been a real bear to track down.

Reviewed-by: Jeff Moyer <jmoyer@...hat.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/