linux-kernel - Re: [patch] apparmor: issue with ns name without a following profile

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 12 Aug 2010 11:15:48 -0400
From:	John Johansen <john.johansen@...onical.com>
To:	Dan Carpenter <error27@...il.com>,
	James Morris <jmorris@...ei.org>,
	linux-security-module@...r.kernel.org,
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [patch] apparmor: issue with ns name without a following profile

On 08/07/2010 04:50 AM, Dan Carpenter wrote:
> If we have a ns name without a following profile then in the original
> code it did "*ns_name = &name[1];".  "name" is NULL so "*ns_name" is
> 0x1.  That isn't useful and could cause an oops when this function is
> called from aa_remove_profiles(). 
> 
> Signed-off-by: Dan Carpenter <error27@...il.com>

Indeed.  I am sorry to say this case was not enabled in the test suite :(
However proposed patch is incorrect, in that it results in namespace
name that starts at &name[1].

I've attached two patches, the first fixes this issue, and the second
fixes a locking bug in namespace removal, for this case (ie. where
there is no profile name specified.

Thanks for catching this

John


View attachment "0001-AppArmor-Fix-splitting-an-fqname-into-separate-names.patch" of type "text/x-diff" (1645 bytes)

View attachment "0002-AppArmor-Fix-locking-from-removal-of-profile-namespa.patch" of type "text/x-diff" (1593 bytes)