linux-kernel - Re: [PATCH v2] SCSI: fix bio.bi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100812160630.GB28689@lst.de>
Date:	Thu, 12 Aug 2010 18:06:30 +0200
From:	Christoph Hellwig <hch@....de>
To:	Jiri Slaby <jslaby@...e.cz>
Cc:	akpm@...ux-foundation.org, linux-raid@...r.kernel.org,
	linux-scsi@...r.kernel.org, jirislaby@...il.com,
	linux-kernel@...r.kernel.org,
	"James E.J. Bottomley" <James.Bottomley@...e.de>,
	Christoph Hellwig <hch@....de>
Subject: Re: [PATCH v2] SCSI: fix bio.bi_rw handling

On Thu, Aug 12, 2010 at 02:31:05PM +0200, Jiri Slaby wrote:
> Return of the bi_rw tests is no longer bool after commit 74450be1. So
> testing against constants doesn't make sense anymore. Fix this bug in
> osd_req_read by removing "== 1" in test.
> 
> This is not a problem now, where REQ_WRITE is 1, but this can change
> in the future and we don't want to rely on that.

And it's much cleaner anyway.  Note that I think we particularly need
the WARN_ON anyway.


Reviewed-by: Christoph Hellwig <hch@....de>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/