linux-kernel - Re: [PATCH v2] input: mouse: add qci touchpad driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4C642E6D.6000908@codeaurora.org>
Date:	Thu, 12 Aug 2010 10:25:01 -0700
From:	Stepan Moskovchenko <stepanm@...eaurora.org>
To:	Neil Leeder <nleeder@...eaurora.org>
CC:	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	linux-input@...r.kernel.org, linux-arm-msm@...r.kernel.org,
	linux-kernel@...r.kernel.org, Horace Fu <horace.fu@...ntatw.com>,
	Mandeep Singh Baines <msb@...omium.org>
Subject: Re: [PATCH v2] input: mouse: add qci touchpad driver

  On 8/12/2010 9:49 AM, Neil Leeder wrote:
> This driver is for the QCI trackpad used on Quanta smartbooks
>
> Signed-off-by: Horace Fu<horace.fu@...ntatw.com>
> Signed-off-by: Mandeep Singh Baines<msb@...omium.org>
> [nleeder@...eaurora.org: cleanup i2c calls, address review comments etc]
> Signed-off-by: Neil Leeder<nleeder@...eaurora.org>
> ---
>   drivers/input/mouse/Kconfig        |   12 ++
>   drivers/input/mouse/Makefile       |    1 +
>   drivers/input/mouse/qci_touchpad.c |  270 ++++++++++++++++++++++++++++++++++++
>   include/linux/input/qci_touchpad.h |   25 ++++
>   4 files changed, 308 insertions(+), 0 deletions(-)
>   create mode 100644 drivers/input/mouse/qci_touchpad.c
>   create mode 100644 include/linux/input/qci_touchpad.h
>
> diff --git a/drivers/input/mouse/Kconfig b/drivers/input/mouse/Kconfig
> index c714ca2..32a88b4 100644
> --- a/drivers/input/mouse/Kconfig
> +++ b/drivers/input/mouse/Kconfig
> @@ -303,6 +303,18 @@ config MOUSE_MAPLE
>   	  To compile this driver as a module choose M here: the module will be
>   	  called maplemouse.
>
> +config MOUSE_QCITP
> +	tristate "Quanta Computer Inc. Touchpad"
> +	depends on I2C
> +	help
> +	  This driver supports the touchpad on Quanta smartbook devices.
> +
> +	  Say Y here if you have a Quanta-based smartboot or notepad
Sorry, very minor point - do you mean "smartbook" here?

A lot of machines are made by Quanta. Should this be given a description 
/ option name that is more specific, ie, "Quanta [chip name] Touchpad" 
or even "Quanta I2C Touchpad" ?  What you have might be fine, however...

Steve

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/