[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20100812182000.GD21829@ghostprotocols.net>
Date: Thu, 12 Aug 2010 15:20:00 -0300
From: Arnaldo Carvalho de Melo <acme@...radead.org>
To: Tom Zanussi <tzanussi@...il.com>
Cc: eranian@...gle.com, linux-kernel@...r.kernel.org, mingo@...e.hu,
fweisbec@...il.com, peterz@...radead.org
Subject: Re: [PATCH] perf trace: get rid of the hard-coded paths in the
report scripts
Em Thu, Aug 12, 2010 at 12:59:18PM -0500, Tom Zanussi escreveu:
> The perf trace report shell scripts hard-code the exec path of the
> scripts into their command-lines, which doesn't work if perf has been
> installed somewhere else.
>
> Instead, perf trace should create the paths at run-time. This patch
> does that and removes the hard-coded paths from all the report scripts.
>
> v2 changes: The first version inadvertantly caused scripts run from
> outside the perf exec path to fail e.g. 'perf trace -s test.py'. The
> fix is to try the script name without the exec path first, then the
> version using the exec path, which restores the expected behavior.
>
> Reported-by: Stephane Eranian <eranian@...gle.com>
> Signed-off-by: Tom Zanussi <tzanussi@...il.com>
Stephane,
Lemme know when you tried this patch so that I can merge it with
a Tested-by: you tag, ok?
- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists