linux-kernel - Re: rtc/m41t80: use rtc_valid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTin7+UPYJ5tsyrbUhxcEfbHLMVJQOSrV1_3zQ0V3@mail.gmail.com>
Date:	Thu, 12 Aug 2010 23:27:32 +0200
From:	Geert Uytterhoeven <geert@...ux-m68k.org>
To:	Wan ZongShun <mcuos.com@...il.com>,
	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Alessandro Zummo <a.zummo@...ertech.it>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: rtc/m41t80: use rtc_valid_tm() to check returned tm

On Wed, Aug 11, 2010 at 18:59, Linux Kernel Mailing List
<linux-kernel@...r.kernel.org> wrote:
> Gitweb:     http://git.kernel.org/linus/b485fe5ea1008db02abff9ef15be4f31b52df4f7

>    rtc/m41t80: use rtc_valid_tm() to check returned tm
>
>    Use rtc_valid_tm() to check returned struct rtc_time *tm - it can avoid
>    returning wrong tm value.

> diff --git a/drivers/rtc/rtc-m41t80.c b/drivers/rtc/rtc-m41t80.c
> index 6dc4e62..66377f3 100644
> --- a/drivers/rtc/rtc-m41t80.c
> +++ b/drivers/rtc/rtc-m41t80.c

> @@ -364,7 +364,7 @@ static int m41t80_rtc_read_alarm(struct device *dev, struct rtc_wkalrm *t)
>        t->time.tm_isdst = -1;
>        t->enabled = !!(reg[M41T80_REG_ALARM_MON] & M41T80_ALMON_AFE);
>        t->pending = !!(reg[M41T80_REG_FLAGS] & M41T80_FLAGS_AF);
> -       return 0;
> +       return rtc_valid_tm(t);

warning: passing argument 1 of ‘rtc_valid_tm’ from incompatible pointer type

`t' is of type `struct rtc_wkalrm *', not `struct rtc_time *'.
Probably the intention was:

        return rtc_valid_tm(&t->time);

??

>  }

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/