linux-kernel - Re: [PATCH] nconfig: Fix segfault when menu is empty

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 13 Aug 2010 00:28:43 +0200
From:	Michal Marek <mmarek@...e.cz>
To:	Andrej Gelenberg <andrej.gelenberg@....edu>
Cc:	linux-kbuild@...r.kernel.org, linux-kernel@...r.kernel.org,
	Nir Tzachar <nir.tzachar@...il.com>
Subject: Re: [PATCH] nconfig: Fix segfault when menu is empty

On Mon, Aug 02, 2010 at 11:59:31AM +0200, Andrej Gelenberg wrote:
> there is a small bug in nconf, which cause segfault in empty menus
> (press right arrow in empty menu). Patch is attached.
> 
> Regards,
> Andrej Gelenberg

> From 60265c2f3db2616d3dc493785a47a301f73419bd Mon Sep 17 00:00:00 2001
> From: Andrej Gelenberg <andrej.gelenberg@....edu>
> Date: Mon, 2 Aug 2010 11:41:36 +0200
> Subject: [PATCH] nconfig: Fix segfault when menu is empty
> 
> nconf crush with segfault if press right arrow in empty menu.
> 
> Signed-off-by: Andrej Gelenberg <andrej.gelenberg@....edu>
> ---
>  scripts/kconfig/nconf.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/scripts/kconfig/nconf.c b/scripts/kconfig/nconf.c
> index 762caf8..3db3ca6 100644
> --- a/scripts/kconfig/nconf.c
> +++ b/scripts/kconfig/nconf.c
> @@ -676,6 +676,7 @@ static void *item_data(void)
>  	struct mitem *mcur;
>  
>  	cur = current_item(curses_menu);
> +	if ( ! cur ) return NULL;
>  	mcur = (struct mitem *) item_userptr(cur);
>  	return mcur->usrptr;

Applied after fixing indentation (see Documentation/CodingStyle).

Michal
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/