linux-kernel - [PATCH] video: v4l2-ctrls.c missing include

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Fri, 13 Aug 2010 21:14:20 +0900
From:	Jerome Pinot <ngc891@...il.com>
To:	Hans Verkuil <hverkuil@...all.nl>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Jiri Kosina <trivial@...nel.org>,
	Linus Torvalds <torvalds@...l.org>
Subject: [PATCH] video: v4l2-ctrls.c missing include

A missing include in drivers/media/video/v4l2-ctrls.c makes the kernel
(2.6.35-07788-g320b2b8) fail to build:

  CC      drivers/media/video/v4l2-ctrls.o
drivers/media/video/v4l2-ctrls.c: In function ‘v4l2_ctrl_handler_init’:
drivers/media/video/v4l2-ctrls.c:766: error: implicit declaration of
function ‘kzalloc’
drivers/media/video/v4l2-ctrls.c:767: warning: assignment makes
pointer from integer without a cast
drivers/media/video/v4l2-ctrls.c: In function ‘v4l2_ctrl_handler_free’:
drivers/media/video/v4l2-ctrls.c:786: error: implicit declaration of
function ‘kfree’
drivers/media/video/v4l2-ctrls.c: In function ‘handler_new_ref’:
drivers/media/video/v4l2-ctrls.c:896: warning: assignment makes
pointer from integer without a cast
drivers/media/video/v4l2-ctrls.c: In function ‘v4l2_ctrl_new’:
drivers/media/video/v4l2-ctrls.c:975: warning: assignment makes
pointer from integer without a cast
drivers/media/video/v4l2-ctrls.c: In function ‘v4l2_g_ext_ctrls’:
drivers/media/video/v4l2-ctrls.c:1528: error: implicit declaration of
function ‘kmalloc’
drivers/media/video/v4l2-ctrls.c:1528: warning: assignment makes
pointer from integer without a cast
drivers/media/video/v4l2-ctrls.c: In function ‘try_set_ext_ctrls’:
drivers/media/video/v4l2-ctrls.c:1752: warning: assignment makes
pointer from integer without a cast
make[3]: *** [drivers/media/video/v4l2-ctrls.o] Error 1
make[2]: *** [drivers/media/video] Error 2
make[1]: *** [drivers/media] Error 2
make: *** [drivers] Error 2

The following trivial patch corrects this.

Signed-off-by: Jerome Pinot <ngc891@...il.com>
--
diff --git a/drivers/media/video/v4l2-ctrls.c b/drivers/media/video/v4l2-ctrls.c
index 84c1a53..ea8d32c 100644
--- a/drivers/media/video/v4l2-ctrls.c
+++ b/drivers/media/video/v4l2-ctrls.c
@@ -19,6 +19,7 @@
  */

 #include <linux/ctype.h>
+#include <linux/slab.h>
 #include <media/v4l2-ioctl.h>
 #include <media/v4l2-device.h>
 #include <media/v4l2-ctrls.h>



-- 
Jérôme Pinot
http://ngc891.blogdns.net/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/