linux-kernel - Re: Q. NFS, return value of close(2)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Fri, 13 Aug 2010 14:25:40 +0200
From:	Milan Broz <mbroz@...hat.com>
To:	Trond Myklebust <Trond.Myklebust@...app.com>
CC:	"J. R. Okajima" <hooanon05@...oo.co.jp>,
	linux-fsdevel@...r.kernel.org,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: Q. NFS, return value of close(2)

On 08/11/2010 07:06 PM, Trond Myklebust wrote:
>> commit e56f956a08a6227004cd9b7747df6a089dbb3594
>> Author: J. R. Okajima <hooanon05@...oo.co.jp>
>> Date:   Thu Aug 12 02:00:02 2010 +0900
>>
>>     NFS: fix the return value of nfs_file_fsync()
>>     
>>     By the commit
>>     	af7fa16 2010-08-03 NFS: Fix up the fsync code
>>     close(2) became returning the non-zero value even if it went well.
>>     nfs_file_fsync() should return 0 when "status" is positive.
>>     
>>     Signed-off-by: J. R. Okajima <hooanon05@...oo.co.jp>

Hi,

please can you send this patch to Linus' tree?
NFS is currently broken, so it will save time for people trying
to bisect the problem.

It breaks even elementary operation on nfs mounts
# cat a > b
cat: write error

Patch above from nfs-git fixed the problem for me
http://git.linux-nfs.org/?p=trondmy/nfs-2.6.git;a=commitdiff;h=0702099bd86c33c2dcdbd3963433a61f3f503901

Thanks,
Milan
--
mbroz@...hat.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/