linux-kernel - Re: [PATCHv8 04/13] USB: gadget: mass_storage: moved strings handling code to composite

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.44L0.1008131110130.12397-100000@netrider.rowland.org>
Date:	Fri, 13 Aug 2010 11:15:15 -0400 (EDT)
From:	Alan Stern <stern@...land.harvard.edu>
To:	David Brownell <david-b@...bell.net>
cc:	linux-usb@...r.kernel.org, Greg KH <greg@...ah.com>,
	Michal Nazarewicz <m.nazarewicz@...sung.com>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCHv8 04/13] USB: gadget: mass_storage: moved strings handling
 code to composite

On Thu, 12 Aug 2010, David Brownell wrote:

> Looks OK, but I can't test or give it
> a detailed review just now.  An ACK from
> Alan would be nice.

There's nothing obviously wrong with this change.  However based on all
the preceding discussion, I now think the best approach may be _never_
to make up a fake serial number.  Use the module parameter, if any, and
otherwise issue a warning and don't have a serial number string
descriptor (even though that violates the spec).

At this point it should be easy to write a patch to implement and
document the new behavior, for both file-storage and mass-storage.

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/