Message-ID: <AANLkTi=SZoRmQyBm0Gs1kp-4nTrDy-ktmWppwgneQghG@mail.gmail.com>
Date:	Fri, 13 Aug 2010 12:29:08 -0700
From:	Brian Swetland <swetland@...gle.com>
To:	"Ted Ts'o" <tytso@....edu>,
	James Bottomley <James.Bottomley@...e.de>,
	Felipe Contreras <felipe.contreras@...il.com>,
	paulmck@...ux.vnet.ibm.com, david@...g.hm, peterz@...radead.org,
	Brian Swetland <swetland@...gle.com>,
	linux-kernel@...r.kernel.org, galibert@...ox.com,
	florian@...kler.org, menage@...gle.com,
	linux-pm@...ts.linux-foundation.org, swmike@....pp.se,
	tglx@...utronix.de, Alan Cox <alan@...rguk.ukuu.org.uk>,
	arjan@...radead.org
Subject: Re: [linux-pm] Attempted summary of suspend-blockers LKML thread,
 take three

On Fri, Aug 13, 2010 at 12:08 PM, Ted Ts'o <tytso@....edu> wrote:
> On Fri, Aug 13, 2010 at 01:11:29PM -0400, James Bottomley wrote:
>>
>> The facts are that suspend blockers identifies a race within our suspend
>> to ram system that permeates from top to bottom (that's from server to
>> mobile).  The problem is that resume events are racy with respect to
>> suspend and vice versa.  This manifests itself most annoyingly on my
>> laptop in the "double suspend" case: where I suspend with a pending
>> suspend event, my laptop will resume and then immediately re-suspend
>> (leading me to kick myself and remind myself to check it stayed up
>> before pushing unsuspend and walking away).  The other annoying case is
>> that if I accidentally close the lid before presenting, I have to wait
>> until the system is fully down before pressing resume.
>
> This is all true, but it's also only one aspect of the problem.  I
> agree with you that this is the part of the problem which affects
> Linux at all scales, from Cloud servers in a data center that want to
> suspend themselves when there's no work to do (and then fail to
> respond to the WOL packet) to mobile platforms that are suspending
> much more frequently.
>
> However, it doesn't follow that this is the _only_ problem that the
> Android folks might be interested in solving.  Opportunistic suspend
> is a different part of the problem space, which is generally believed
> by the Android developers as being far more efficient than a
> user-space suspend manager.  Rafael has stated his complete
> unwillingness to deal with this part of the problem.  OK, so that
> probably means that for Android, it will have to be an out-of-tree
> kernel patch.
>
> The question, then, is whether a solution which addresses the only
> part of the problem which Rafael is interested in dealing with at this
> point, is sufficient such that (a) the kernel-level opportunistic
> suspend can be done as an out-of-tree patch, while simultaneously (b)
> allowing device drivers for Android devices can utilize Rafael's
> interfaces to solve the race design bug currently found in our suspend
> subsystem, while (c) requiring minimal changes to the Android
> userspace, and (d) providing all of the statistics and debugging
> functionality required by the Android userspace.
>
> If we can engineer a solution which meets (a), (b), (c), and (d)
> above, then everyone will be happy.

Arve's suspend blockers patch stack actually separates the core
functionality (ability for drivers to delay suspend while doing work
suspend would interfere with), from the ability to hold suspend
blockers from userspace (a separate, smaller patch building on the
core functionality).

Brian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists