linux-kernel - Re: Problem with commit deda2e81961e96be4f2c09328baca4710a2fd1a0

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 12 Aug 2010 22:17:14 -0500
From:	Larry Finger <Larry.Finger@...inger.net>
To:	john stultz <johnstul@...ibm.com>
CC:	Jason Wessel <jason.wessel@...driver.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: Problem with commit deda2e81961e96be4f2c09328baca4710a2fd1a0

On 08/12/2010 03:52 PM, john stultz wrote:
> 
> Ugh. I'm surprised it picks *this* loop to optimize instead of the
> similar one right above. I'm guessing its the local raw_nsecs value, but
> whatever.  Also surprised Jason's testing didn't hit this issue, but its
> probably a gcc version thing.
> 
> Regardless, I clearly need to give i386 more love in my testing.
> My profuse apologies.
> 
> As suggested by Linus, here's the do_div explicit version. It builds ok
> on i386 & x86_64, but I have not yet tested it. 
> 
> Larry, Jason: Could you verify it works for you (and avoids the original
> issue)?

This one builds for me with both compilers. It appears to run OK. As to the
original issue - I don't think I ever saw the problem. I'll leave that question
for Jason.

Larry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/