linux-kernel - linux-next: build failure after merge of the acpi tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Fri, 13 Aug 2010 10:56:02 +1000
From:	Stephen Rothwell <sfr@...b.auug.org.au>
To:	Len Brown <lenb@...nel.org>
Cc:	linux-next@...r.kernel.org, linux-kernel@...r.kernel.org,
	Zhang Rui <rui.zhang@...el.com>
Subject: linux-next: build failure after merge of the acpi tree

Hi Len,

After merging the acpi tree, today's linux-next build (x86_64
allmodconfig) failed like this:

drivers/acpi/debugfs.c: In function 'cm_write':
drivers/acpi/debugfs.c:36: error: implicit declaration of function 'copy_from_user'

Caused by commit c0b82d427637c7598af5d7926187a7781c03bce8 ("ACPI:
introduce drivers/acpi/debugfs.c"), interacting with something that
stopped linux/uaccess.h from being implicitly included.  See Rule 1 in
Documentation/SubmitChecklist.

I have added the following patch for today:

From: Stephen Rothwell <sfr@...b.auug.org.au>
Date: Fri, 13 Aug 2010 10:52:30 +1000
Subject: [PATCH] acpi: using copy_from_user needs linux/uaccess.h

fixes this build error:

drivers/acpi/debugfs.c: In function 'cm_write':
drivers/acpi/debugfs.c:36: error: implicit declaration of function 'copy_from_user'

Signed-off-by: Stephen Rothwell <sfr@...b.auug.org.au>
---
 drivers/acpi/debugfs.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/acpi/debugfs.c b/drivers/acpi/debugfs.c
index f0cd0e7..4f19078 100644
--- a/drivers/acpi/debugfs.c
+++ b/drivers/acpi/debugfs.c
@@ -6,6 +6,7 @@
 #include <linux/module.h>
 #include <linux/kernel.h>
 #include <linux/debugfs.h>
+#include <linux/uaccess.h>
 #include <acpi/acpi_drivers.h>
 
 #define _COMPONENT		ACPI_SYSTEM_COMPONENT
-- 
1.7.1

-- 
Cheers,
Stephen Rothwell                    sfr@...b.auug.org.au
http://www.canb.auug.org.au/~sfr/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/