linux-kernel - Re: [PATCH v2] input: mouse: add qci touchpad driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4C6511AD.4060800@codeaurora.org>
Date:	Fri, 13 Aug 2010 15:04:37 +0530
From:	Trilok Soni <tsoni@...eaurora.org>
To:	"Datta, Shubhrajyoti" <shubhrajyoti@...com>
CC:	Neil Leeder <nleeder@...eaurora.org>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	"linux-input@...r.kernel.org" <linux-input@...r.kernel.org>,
	"linux-arm-msm@...r.kernel.org" <linux-arm-msm@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Horace Fu <horace.fu@...ntatw.com>,
	Mandeep Singh Baines <msb@...omium.org>
Subject: Re: [PATCH v2] input: mouse: add qci touchpad driver

Hi Shubhrajyoti,

>> +
>> +gpio_request_fail:
>> +	input_unregister_device(context->qcitp_dev);
>> +	context->qcitp_dev = NULL;
>> +
>> +register_fail:
>> +	input_free_device(context->qcitp_dev);
> You may like to revisit the use of free after unregister.
> 

That looks OK, because qcitp_dev is set to NULL before this call.

---Trilok Soni

-- 
Sent by a consultant of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/