linux-kernel - RE: [patch] qla4xxx: initialize some variables for gcc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 13 Aug 2010 19:40:51 -0700
From:	Vikas Chaudhary <vikas.chaudhary@...gic.com>
To:	Dan Carpenter <error27@...il.com>,
	Ravi Anand <ravi.anand@...gic.com>
CC:	Dept_iscsi_driver <iscsi-driver@...gic.com>,
	"James E.J. Bottomley" <James.Bottomley@...e.de>,
	Karen Higgins <karen.higgins@...gic.com>,
	"linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>
Subject: RE: [patch] qla4xxx: initialize some variables for gcc

>-----Original Message-----
>From: Dan Carpenter [mailto:error27@...il.com]
>Sent: Saturday, August 14, 2010 2:34 AM
>To: Ravi Anand
>Cc: Vikas Chaudhary; Dept_iscsi_driver; James E.J. Bottomley; Karen
>Higgins; linux-scsi@...r.kernel.org; linux-kernel@...r.kernel.org; kernel-
>janitors@...r.kernel.org
>Subject: [patch] qla4xxx: initialize some variables for gcc
>
>Gcc complains because these variables aren't initialized.
>
>drivers/scsi/qla4xxx/ql4_nx.c: In function ‘qla4_8xxx_get_flash_info’:
>drivers/scsi/qla4xxx/ql4_nx.c:1952: warning: ‘fid’ may be used
>uninitialized in this function
>drivers/scsi/qla4xxx/ql4_nx.c:1952: note: ‘fid’ was declared here
>drivers/scsi/qla4xxx/ql4_nx.c:1952: warning: ‘mid’ may be used
>uninitialized in this function
>drivers/scsi/qla4xxx/ql4_nx.c:1952: note: ‘mid’ was declared here
>
>It's not a big deal.  We only print the uninitialized value on error
>paths when debugging is enabled.  Still it's nice to clean it up and to
>stop gcc from grumbling.
>
>Signed-off-by: Dan Carpenter <error27@...il.com>
>
>diff --git a/drivers/scsi/qla4xxx/ql4_nx.c b/drivers/scsi/qla4xxx/ql4_nx.c
>index 3e119ae..e443fa6 100644
>--- a/drivers/scsi/qla4xxx/ql4_nx.c
>+++ b/drivers/scsi/qla4xxx/ql4_nx.c
>@@ -1949,7 +1949,8 @@ qla4_8xxx_get_fdt_info(struct scsi_qla_host *ha)
> 	uint16_t cnt, chksum;
> 	uint16_t *wptr;
> 	struct qla_fdt_layout *fdt;
>-	uint16_t mid, fid;
>+	uint16_t mid = -1;
>+	uint16_t fid = -1;
> 	struct ql82xx_hw_data *hw = &ha->hw;
>
> 	hw->flash_conf_off = FARX_ACCESS_FLASH_CONF;

I already submitted patch to fix this warning in following mail thread.
http://marc.info/?l=linux-scsi&m=128152158403853&w=2