| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Fri, 13 Aug 2010 20:23:42 -0400 (EDT) From: Alan Stern <stern@...land.harvard.edu> To: David Brownell <david-b@...bell.net> cc: linux-usb@...r.kernel.org, Greg KH <greg@...ah.com>, Michal Nazarewicz <m.nazarewicz@...sung.com>, <linux-kernel@...r.kernel.org> Subject: Re: [PATCHv8 04/13] USB: gadget: mass_storage: moved strings handling code to composite On Fri, 13 Aug 2010, David Brownell wrote: > --- On Fri, 8/13/10, Alan Stern <stern@...land.harvard.edu> wrote: > . > > ... based on all > > the preceding discussion, I now think the best > > approach may be _never > > to make up a fake serial number. Use the module > > parameter, if any, and > > otherwise issue a warning and don't have > > a serial number string > > descriptor (even though that violates the spec). > > > Agreed, and that's what I had asked for. I didn't > see code faking up a serial ... did I miss such? That code has been present in g_file_storage since the beginning. There were some patches earlier which moved the code to a different location. I guess you missed it. The current round of patches doesn't touch that code. > If so, let's see a new patch with no faking. An extra patch or two would be needed to remove the fake-serial generation. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists