linux-kernel - Re: [PATCH] kvm: make mmu_shrink() fit shrinker's requirement

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4C67CC06.7070707@redhat.com>
Date:	Sun, 15 Aug 2010 14:14:14 +0300
From:	Avi Kivity <avi@...hat.com>
To:	Dave Hansen <dave@...ux.vnet.ibm.com>
CC:	Lai Jiangshan <laijs@...fujitsu.com>,
	Marcelo Tosatti <mtosatti@...hat.com>,
	LKML <linux-kernel@...r.kernel.org>, kvm@...r.kernel.org
Subject: Re: [PATCH] kvm: make mmu_shrink() fit shrinker's requirement

  On 08/13/2010 11:10 PM, Dave Hansen wrote:
> On Thu, 2010-08-05 at 12:28 +0300, Avi Kivity wrote:
>> On 08/04/2010 10:13 AM, Lai Jiangshan wrote:
>>> mmu_shrink() should attempt to free @nr_to_scan entries.
>> This conflicts with Dave's patchset.
>>
>> Dave, what's going on with those patches?  They're starting to smell.
> These seem to fix the original problem reporter's issue.  They were run
> with 64 guests on a 32GB machine.  No stability problems popped up in
> this testing, or since I last sent the patches to you.  The results from
> both the test with only the first four patches and with the entire set
> of nine looked pretty identical.
>
> That tells me that we should only push the first four for now:
>
> 	abstract kvm x86 mmu->n_free_mmu_pages
> 	rename x86 kvm->arch.n_alloc_mmu_pages
> 	replace x86 kvm n_free_mmu_pages with n_used_mmu_pages
> 	create aggregate kvm_total_used_mmu_pages value

Well, patches 3 and 4 have unaddressed review comments. Please fix them 
up. If you don't have the time, let me know and I'll do it instead.

-- 
error compiling committee.c: too many arguments to function

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/