lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <1281945071.3449.4.camel@maxim-laptop>
Date:	Mon, 16 Aug 2010 10:51:11 +0300
From:	Maxim Levitsky <maximlevitsky@...il.com>
To:	Uwe Kleine-König 
	<u.kleine-koenig@...gutronix.de>
Cc:	linux-kernel@...r.kernel.org, David Brownell <david-b@...bell.net>,
	Alan Stern <stern@...land.harvard.edu>,
	linux-mmc@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] mmc: build fix: mmc_pm_notify is only available with
 CONFIG_PM=y

On Fri, 2010-08-13 at 13:01 +0300, Maxim Levitsky wrote: 
> On Fri, 2010-08-13 at 11:24 +0200, Uwe Kleine-König wrote: 
> > This fixes a build breakage introduced by
> > 
> > 	4c2ef25 (mmc: fix all hangs related to mmc/sd card insert/removal during suspend/resume)
> > 
> > Cc: Maxim Levitsky <maximlevitsky@...il.com>
> > Cc: David Brownell <david-b@...bell.net>
> > Cc: Alan Stern <stern@...land.harvard.edu>
> > Cc: linux-mmc@...r.kernel.org
> > Cc: Andrew Morton <akpm@...ux-foundation.org>
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> > ---
> >  drivers/mmc/core/host.c |    2 ++
> >  1 files changed, 2 insertions(+), 0 deletions(-)
> > 
> > diff --git a/drivers/mmc/core/host.c b/drivers/mmc/core/host.c
> > index 0efe631..d80cfdc 100644
> > --- a/drivers/mmc/core/host.c
> > +++ b/drivers/mmc/core/host.c
> > @@ -86,7 +86,9 @@ struct mmc_host *mmc_alloc_host(int extra, struct device *dev)
> >  	init_waitqueue_head(&host->wq);
> >  	INIT_DELAYED_WORK(&host->detect, mmc_rescan);
> >  	INIT_DELAYED_WORK_DEFERRABLE(&host->disable, mmc_host_deeper_disable);
> > +#ifdef CONFIG_PM
> >  	host->pm_notify.notifier_call = mmc_pm_notify;
> > +#endif
> >  
> >  	/*
> >  	 * By default, hosts do not support SGIO or large requests.
> 
> Hi,
> 
> Sorry about that!


Hi folks,

Sorry again for this bug.
>>From now on I will test compilation rigorously. 

If you need it,
Acked-by: Maxim Levitsky <maximlevitsky@...il.com>

Best regards,
Maxim Levitsky

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ