linux-kernel - Re: [PATCH] modules: don't call depmod when overriding external module install path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201008162013.46252.rusty@rustcorp.com.au>
Date:	Mon, 16 Aug 2010 20:13:45 +0930
From:	Rusty Russell <rusty@...tcorp.com.au>
To:	Jon Masters <jcm@...masters.org>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Michal Marek <mmarek@...e.cz>, linux-kbuild@...r.kernel.org
Subject: Re: [PATCH] modules: don't call depmod when overriding external module install path

On Mon, 16 Aug 2010 05:33:34 pm Jon Masters wrote:
> Recent kernels include an additional call to depmod during the installation
> of external kernel modules as a convenience, in order to ensure that those
> modules are picked up by the module loading tools/initramfs scripts, etc.
> Although this call is potentially of some value, it should not be made
> when explicitly setting INSTALL_MOD_PATH to a different location. This
> avoids creating extraneous modules.* files that will never be used.
> 
> Signed-off-by: Jon Masters <jcm@...masters.org>

Acked-by: Rusty Russell <rusty@...tcorp.com.au>

I leave the Makefile stuff to the kbuild people...

> ---
>  Makefile |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/Makefile b/Makefile
> index f3bdff8..2b904f2 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -1325,7 +1325,9 @@ _emodinst_:
>  
>  PHONY += _emodinst_post
>  _emodinst_post: _emodinst_
> +ifeq ($(INSTALL_MOD_PATH),)
>  	$(call cmd,depmod)
> +endif
>  
>  clean-dirs := $(addprefix _clean_,$(KBUILD_EXTMOD))

Thanks,
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/