linux-kernel - Re: [RFC PATCH] of/microblaze: fix includes so that asm/prom.h doesn't need linux/of*.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 17 Aug 2010 01:17:21 -0600
From:	Grant Likely <grant.likely@...retlab.ca>
To:	monstr@...str.eu
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH] of/microblaze: fix includes so that asm/prom.h
 doesn't need linux/of*.h

On Tue, Aug 17, 2010 at 1:12 AM, Grant Likely <grant.likely@...retlab.ca> wrote:
> On Tue, Aug 17, 2010 at 12:15 AM, Michal Simek <monstr@...str.eu> wrote:
>> Grant Likely wrote:
>>>
>>> asm/prom.h has some nasty include ordering issues because a number of
>>> files assume that linux/of_* is included by prom.h.  This patch fixes
>>> the Microblaze occurrences.
>>>
>>> Signed-off-by: Grant Likely <grant.likely@...retlab.ca>
>>> ---
>>>
>>> Hi Michal,
>>>
>>> And here is my patch that fixes all the include issues so the remaining
>>> lines
>>> can be removed from prom.h.  I'll add this one to my test-devicetree
>>> branch
>>> along with similar patches to fix powerpc and sparc, and probably merge it
>>> in 2.6.37.
>>
>> That's bad because I don't want to keep pci broken till 2.6.37 especially in
>> case that I know that is broken.
>>
>> If this is the right fix for my issue and you want to merge it in 2.6.37
>> then I prefer to use my patch which simple add one header to prom.h and then
>> this patch fix it in general in 2.6.37.
>>
>> What do you think?
>
> heh, I think we're talking across purposes.  I sent 2 patches.
>
> The first patch fixes your immediate issue, and I'll ask Linus to
> merge it tomorrow.
> The second patch (this patch) allows the rest of the linux/of*.h
> includes to be removed from prom.h, but I will not merge that one into
> 2.6.36 because it is riskier and it isn't a regression fix.

...and here's the link to the first patch in case it somehow missed your inbox:

http://lkml.org/lkml/2010/8/17/46

g.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/