linux-kernel - Re: [patch] pata_winbond: fix module init

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100817110733.1c57aedd@lxorguk.ukuu.org.uk>
Date:	Tue, 17 Aug 2010 11:07:33 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Dan Carpenter <error27@...il.com>
Cc:	Bartlomiej Zolnierkiewicz <bzolnier@...il.com>,
	Jeff Garzik <jgarzik@...ox.com>, linux-ide@...r.kernel.org,
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [patch] pata_winbond: fix module init

On Tue, 17 Aug 2010 08:29:40 +0200
Dan Carpenter <error27@...il.com> wrote:

> On Mon, Aug 16, 2010 at 09:23:03PM +0200, Bartlomiej Zolnierkiewicz wrote:
> > 
> > Hi Dan,
> > 
> > On Tuesday 03 August 2010 05:27:47 pm Dan Carpenter wrote:
> > > winbond_init_one() returns 0 on success and an error code on failure.
> > > In the original code, we always just released the regions and return
> > > -ENODEV.  This was introduce in 2006 by 7e45b0e5f6f6 "[PATCH] libata:
> > > Winbond support".
> > 
> > You might like to pick up
> > 
> > 	http://patchwork.ozlabs.org/patch/39358/
> > 
> > instead..
> > 
> 
> I don't have the hardware, but yes, probably it's better to replace this
> driver since it has never been able to load.

It was obsoleted into pata_legacy before it was ever finalised -
unfortunately I could then not get Jeff to delete it.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/