linux-kernel - Re: [PATCH] kconfig: Fix variable name typo in streamline

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1282049925.3268.1294.camel@gandalf.stny.rr.com>
Date:	Tue, 17 Aug 2010 08:58:45 -0400
From:	Steven Rostedt <rostedt@...dmis.org>
To:	hiromu <hiromu1996@...il.com>
Cc:	linux-kernel@...r.kernel.org,
	Américo Wang <xiyou.wangcong@...il.com>,
	Toralf Foerster <toralf.foerster@....de>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>,
	YOSHIFUJI Hideaki <yoshfuji@...ux-ipv6.org>
Subject: Re: [PATCH] kconfig: Fix variable name typo in
 streamline_config.pl.

On Tue, 2010-08-17 at 19:49 +0900, hiromu wrote:
> On Fri, Aug 17, 2010 at 01:43PM +0800, Américo Wang wrote:
> > Acked-by: WANG Cong <xiyou.wangcong@...il.com>
> > 
> > BTW, I think we should add "use strict;" too.
> 
> Then I added "use strict;" to streamline_config.pl, I saw another
> warings.
> 
> > Global symbol "$dir" requires explicit package name at
> scripts/kconfig/streamline_config.pl line 286.
> > Global symbol "$dir" requires explicit package name at
> scripts/kconfig/streamline_config.pl line 287.
> > Global symbol "$dir" requires explicit package name at
> scripts/kconfig/streamline_config.pl line 288.
> 
> Then I added "my $dir;" to line 285.

Thanks! I'll pull this in today.

-- Steve

> 
> Cc: Américo Wang <xiyou.wangcong@...il.com>
> Cc: Steven Rostedt <rostedt@...dmis.org>
> Cc: Toralf Foerster <toralf.foerster@....de>
> Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
> Cc: YOSHIFUJI Hideaki <yoshfuji@...ux-ipv6.org>
> 
> Signed-off-by: Hiromu Yakura <hiromu1996@...il.com>
> ---
>  scripts/kconfig/streamline_config.pl |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/scripts/kconfig/streamline_config.pl
> b/scripts/kconfig/streamline_config.pl
> index d74363f..9ca361a 100644
> --- a/scripts/kconfig/streamline_config.pl
> +++ b/scripts/kconfig/streamline_config.pl
> @@ -42,6 +42,8 @@
>  #    mv config_strip .config
>  #    make oldconfig
>  #
> +use strict;
> +
>  my $config = ".config";
>  
>  my $uname = `uname -r`;
> @@ -280,6 +282,7 @@ if (defined($lsmod_file)) {
>  
>      # see what modules are loaded on this system
>      my $lsmod;
> +    my $dir;
>  
>      foreach $dir ( ("/sbin", "/bin", "/usr/sbin", "/usr/bin") ) {
>         if ( -x "$dir/lsmod" ) {


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/