linux-kernel - Re: [PATCH] scripts: checkpatch.pl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Tue, 17 Aug 2010 17:39:15 +0100
From:	Andy Whitcroft <apw@...onical.com>
To:	Raffaele Recalcati <lamiaposta71@...il.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org,
	Raffaele Recalcati <raffaele.recalcati@...cino.it>,
	Daniel Walker <dwalker@...o99.com>,
	Joe Perches <joe@...ches.com>
Subject: Re: [PATCH] scripts: checkpatch.pl

On Thu, Jun 24, 2010 at 08:27:30AM +0200, Raffaele Recalcati wrote:
> 2010/6/23 Andrew Morton <akpm@...ux-foundation.org>
> 
> > On Wed, 23 Jun 2010 11:49:21 +0200
> > Raffaele Recalcati <lamiaposta71@...il.com> wrote:
> >
> > > From: Raffaele Recalcati <raffaele.recalcati@...cino.it>
> > >
> > > I've got a false positive when spaces are present
> > > at the beginning of a line.
> > > So I add this check, obviously outside comments.
> > > This patch is compatible with the actual mainline,
> > > I mean 7e27d6e778cd87b6f2415515d7127eba53fe5d02 commit.
> >
> > I don't really understand that.  It would help if the changelog
> > were to include a copy of the code which triggers this "false
> > positive", and a copy of the incorrect checkpatch.pl output.
> >
> > Thanks.
> >
> >
> Would be nice a changelog like this?
> 
> ----start changelog-----------
> I've got a false positive when spaces are present at the beginning of a
> line.
> So I add this check, obviously excluding to check the lines in the middle of
> comments.

This check seems to be causing regressions for valid combinations.  I
have a patch to this patch which seems to fix it, I am currently fixing
the test suite and test it generally.

Andrew, will get the delta up to you shortly.

-apw
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/