linux-kernel - RE: [PATCH v2 1/3] libcxgbi: common library for cxgb3i and cxgb4i

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1282004557.24541.2.camel@Joe-Laptop>
Date:	Mon, 16 Aug 2010 17:22:37 -0700
From:	Joe Perches <joe@...ches.com>
To:	Karen Xie <kxie@...lsio.com>
Cc:	open-iscsi@...glegroups.com, linux-kernel@...r.kernel.org,
	linux-scsi@...r.kernel.org, Rakesh Ranjan <rakesh@...lsio.com>,
	James.Bottomley@...senPartnership.com, michaelc@...wisc.edu
Subject: RE: [PATCH v2 1/3] libcxgbi: common library for cxgb3i and cxgb4i

On Mon, 2010-08-16 at 17:02 -0700, Karen Xie wrote:
> Thanks, Joe.
> 
> I will update the patch with your suggestion. BTW, I probably won't use
> pr_<level> just to avoid any confusion since they are already defined in
> kernel.h. I know I can undef them, but rather not to.

Hi Karen.

The point is to use pr_<level> precisely because it is
defined in kernel.h and they are standard kernel functions
commonly used in the rest of the kernel source.

There's no need to undef it any more than there is to
#undef printk or use a #define printf printk

cheers, Joe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/