linux-kernel - Re: [patch -NEXT] usb/gadget/webcam: fix Kconfig depends again

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4C6ACEFB.7060706@oracle.com>
Date:	Tue, 17 Aug 2010 11:03:39 -0700
From:	Randy Dunlap <randy.dunlap@...cle.com>
To:	Laurent Pinchart <laurent.pinchart@...asonboard.com>
CC:	Stephen Rothwell <sfr@...b.auug.org.au>, gregkh@...e.de,
	lud <linux-usb@...r.kernel.org>, linux-next@...r.kernel.org,
	LKML <linux-kernel@...r.kernel.org>,
	David Brownell <dbrownell@...rs.sourceforge.net>
Subject: Re: [patch -NEXT] usb/gadget/webcam: fix Kconfig depends again

On 08/10/10 07:53, Laurent Pinchart wrote:
> Hi Randy,
> 
> On Tuesday 10 August 2010 16:48:57 Randy Dunlap wrote:
>> On 08/10/10 05:16, Laurent Pinchart wrote:
>>> On Monday 09 August 2010 19:55:20 Randy Dunlap wrote:
>>>> From: Randy Dunlap <randy.dunlap@...cle.com>
>>>>
>>>> The USB gadget webcam driver uses V4L2 interfaces, so it should depend
>>>> on VIDEO_V4L2 instead of VIDEO_DEV.  This fixes a lot of build errors
>>>> when V4L2 is not enabled:
>>>>
>>>> ERROR: "v4l2_event_unsubscribe" [drivers/usb/gadget/g_webcam.ko]
>>>> undefined! ERROR: "v4l2_event_queue" [drivers/usb/gadget/g_webcam.ko]
>>>> undefined! ERROR: "video_device_release"
>>>> [drivers/usb/gadget/g_webcam.ko] undefined! ERROR: "video_usercopy"
>>>> [drivers/usb/gadget/g_webcam.ko] undefined! ERROR: "v4l2_event_dequeue"
>>>> [drivers/usb/gadget/g_webcam.ko] undefined! ERROR:
>>>> "video_register_device" [drivers/usb/gadget/g_webcam.ko] undefined!
>>>> ERROR: "video_device_alloc" [drivers/usb/gadget/g_webcam.ko] undefined!
>>>> ERROR: "v4l2_event_subscribe" [drivers/usb/gadget/g_webcam.ko]
>>>> undefined! ERROR: "video_unregister_device"
>>>> [drivers/usb/gadget/g_webcam.ko] undefined!
>>>> ERROR: "v4l2_fh_init" [drivers/usb/gadget/g_webcam.ko] undefined!
>>>> ERROR: "v4l2_event_pending" [drivers/usb/gadget/g_webcam.ko] undefined!
>>>> ERROR: "v4l2_event_init" [drivers/usb/gadget/g_webcam.ko] undefined!
>>>> ERROR: "video_devdata" [drivers/usb/gadget/g_webcam.ko] undefined!
>>>> ERROR: "v4l2_event_alloc" [drivers/usb/gadget/g_webcam.ko] undefined!
>>>> ERROR: "v4l2_fh_add" [drivers/usb/gadget/g_webcam.ko] undefined!
>>>> ERROR: "v4l2_fh_del" [drivers/usb/gadget/g_webcam.ko] undefined!
>>>> ERROR: "v4l2_fh_exit" [drivers/usb/gadget/g_webcam.ko] undefined!
>>>
>>> All those symbols should be defined when VIDEO_DEV is selected.
>>>
>>>> ERROR: "v4l2_ctrl_fill" [drivers/media/video/v4l2-common.ko] undefined!
>>>> ERROR: "v4l2_ctrl_get_menu" [drivers/media/video/v4l2-common.ko]
>>>> undefined!
>>>
>>> Those 2 symbols require VIDEO_V4L2 but are not used by the webcam gadget
>>> driver.
>>>
>>>> ERROR: "v4l2_device_unregister_subdev"
>>>> [drivers/media/video/v4l2-common.ko] undefined!
>>>> ERROR: "v4l2_device_register_subdev"
>>>> [drivers/media/video/v4l2-common.ko] undefined!
>>>
>>> Those two symbols should be defined when VIDEO_DEV is selected. They are
>>> not used by the webcam gadget driver.
>>
>> Summary:  I should drop this patch and look elsewhere for the problem,
>> Right?
> 
> I think the problem comes from somewhere else, yes. Your patch won't hurt, but 
> I don't see how it could fix the problem either.

Agreed.  Patch is withdrawn.  Thanks.

-- 
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/