linux-kernel - Re: [PATCH v2] input: mouse: add qci touchpad driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <BC741E3E-377E-45BF-80E1-A60F4E0FDFC9@gmail.com>
Date:	Tue, 17 Aug 2010 11:05:48 -0700
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	Neil Leeder <nleeder@...eaurora.org>
Cc:	Stepan Moskovchenko <stepanm@...eaurora.org>,
	"linux-input@...r.kernel.org" <linux-input@...r.kernel.org>,
	"linux-arm-msm@...r.kernel.org" <linux-arm-msm@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Horace Fu <horace.fu@...ntatw.com>,
	Mandeep Singh Baines <msb@...omium.org>,
	Trilok Soni <tsoni@...eaurora.org>
Subject: Re: [PATCH v2] input: mouse: add qci touchpad driver

Hi Neil,

On Aug 17, 2010, at 10:14 AM, Neil Leeder <nleeder@...eaurora.org>  
wrote:

> On 8/13/2010 8:54 PM, Dmitry Torokhov wrote:
>> Also it is not a simple coincidence that to enable device you send  
>> 0xf4
>> to it (which is PSMOUSE_CMD_ENABLE - standard PS/2 command). This  
>> tends
>> to suggest that interface is not actually hidden and that the device
>> (touchpad) could be replaced with other kinds of devices.
>>
>> Anyway, please try the driver (you  may need to hardcode the IRQ  
>> trigger
>> type for now) and see if psmouse is able to talk to the touchpad.  
>> If it
>> is then serio is the proper solution.
>
> Dmitri,
> I fixed one line in the wpce775x_serio driver which looked like a  
> typo - hope I got that right:
>
>    for (i = 0; i < count; i++)
> -        serio_interrupt(ps2if->serio, ps2if->data_in[1], 0);
> +        serio_interrupt(ps2if->serio, ps2if->data_in[i], 0);
>    }
>

Yep, that was a typo.

> I tried running with psmouse but it didn't work. The touchpad was  
> never detected as a synaptics touchpad. I looked at the dataflow  
> from the device and it wasn't responding to the commands that  
> synaptics_detect() was sending it. It eventually showed up as an  
> unknown logitech mouse.


That suggests that the device responds to at least basic PS/2 queries.

> I can see data being passed through the serio driver but the  
> logitech driver can't process it.
>

What about loading psmouse module with proto=bare?

Could you also dump the data received from touchpad during probing?


-- 
Dmitry

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/