linux-kernel - Re: [PATCH] kconfig: Fix variable name typo in streamline

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100817054318.GC5095@cr0.nay.redhat.com>
Date:	Tue, 17 Aug 2010 13:43:18 +0800
From:	Américo Wang <xiyou.wangcong@...il.com>
To:	hiromu yagura <hiromu1996@...il.com>
Cc:	linux-kernel@...r.kernel.org, Steven Rostedt <rostedt@...dmis.org>,
	Toralf Foerster <toralf.foerster@....de>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>,
	YOSHIFUJI Hideaki <yoshfuji@...ux-ipv6.org>
Subject: Re: [PATCH] kconfig: Fix variable name typo in
 streamline_config.pl.

On Sun, Aug 15, 2010 at 01:13:17PM +0900, hiromu yagura wrote:
>When I added "use strict;" to streamline_config.pl, I saw following
>warnings.
>
>> Global symbol "%prompt" requires explicit package name at
>scripts/kconfig/streamline_config.pl line 183.
>> Global symbol "%prompt" requires explicit package name at
>scripts/kconfig/streamline_config.pl line 368.
>
>Let's fix it.
>(Note: prompts[] is defined at line 123 but never used. This seems
>typo.)
>
>Cc: Steven Rostedt <rostedt@...dmis.org>
>Cc: Toralf Foerster <toralf.foerster@....de>
>Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
>Cc: YOSHIFUJI Hideaki <yoshfuji@...ux-ipv6.org>
>
>Signed-off-by: Hiromu Yakura <hiromu1996@...il.com>


Acked-by: WANG Cong <xiyou.wangcong@...il.com>

BTW, I think we should add "use strict;" too.

>---
> scripts/kconfig/streamline_config.pl |    4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/scripts/kconfig/streamline_config.pl
>b/scripts/kconfig/streamline_config.pl
>index c70a27d..d74363f 100644
>--- a/scripts/kconfig/streamline_config.pl
>+++ b/scripts/kconfig/streamline_config.pl
>@@ -178,7 +178,7 @@ sub read_kconfig {
> 	# configs without prompts must be selected
> 	} elsif ($state ne "NONE" && /^\s*tristate\s\S/) {
> 	    # note if the config has a prompt
>-	    $prompt{$config} = 1;
>+	    $prompts{$config} = 1;
> 
> 	# Check for if statements
> 	} elsif (/^if\s+(.*\S)\s*$/) {
>@@ -363,7 +363,7 @@ while ($repeat) {
> 	    parse_config_dep_select $depends{$config};
> 	}
> 
>-	if (defined($prompt{$config}) || !defined($selects{$config})) {
>+	if (defined($prompts{$config}) || !defined($selects{$config})) {
> 	    next;
> 	}
> 
>-- 
>1.7.0.4
>
>
>
>--
>To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
>the body of a message to majordomo@...r.kernel.org
>More majordomo info at  http://vger.kernel.org/majordomo-info.html
>Please read the FAQ at  http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/