linux-kernel - Re: [RFC PATCH 01/20] Create generic alignment API (v8)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100818010500.GA2116@Krystal>
Date:	Tue, 17 Aug 2010 21:05:00 -0400
From:	Mathieu Desnoyers <mathieu.desnoyers@...icios.com>
To:	"Kirill A. Shutemov" <kirill@...temov.name>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Imre Deak <imre.deak@...ia.com>,
	Alexander Shishkin <virtuoso@...nd.org>,
	Andi Kleen <andi@...stfloor.org>,
	Masami Hiramatsu <masami.hiramatsu.pt@...achi.com>,
	Christoph Hellwig <hch@....de>,
	Arnaldo Carvalho de Melo <acme@...radead.org>,
	Russell King - ARM Linux <linux@....linux.org.uk>,
	Tom Zanussi <tzanussi@...il.com>,
	ltt-dev@...ts.casi.polymtl.ca,
	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>,
	Ingo Molnar <mingo@...e.hu>,
	Alexey Dobriyan <adobriyan@...il.com>,
	Johannes Berg <johannes.berg@...el.com>,
	Jamie Lokier <jamie@...reable.org>,
	Li Zefan <lizf@...fujitsu.com>,
	Steven Rostedt <rostedt@...dmis.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	linux-arm-kernel@...ts.infradead.org,
	Lai Jiangshan <laijs@...fujitsu.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>
Subject: Re: [RFC PATCH 01/20] Create generic alignment API (v8)

* Kirill A. Shutemov (kirill@...temov.name) wrote:
> > Index: linux.trees.git/include/linux/align.h
> > ===================================================================
> > --- /dev/null	1970-01-01 00:00:00.000000000 +0000
> > +++ linux.trees.git/include/linux/align.h	2010-08-17 16:31:50.000000000 -0400
> > @@ -0,0 +1,56 @@
> > +#ifndef _LINUX_ALIGN_H
> > +#define _LINUX_ALIGN_H
> > +
> > +#define __ALIGN_KERNEL(x, a)	__ALIGN_KERNEL_MASK((x), (typeof(x))(a) - 1)
>                                                     ^^^
> Unnecessary braces. And many below.

Good catch, thanks !

I also found some in:

Ring buffer backend
Ring buffer frontend

patches. I fixed them already, they should be OK in the next round.

Thanks,

Mathieu

-- 
Mathieu Desnoyers
Operating System Efficiency R&D Consultant
EfficiOS Inc.
http://www.efficios.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/