linux-kernel - Re: [PATCH] checkpatch: check for incorrect permissions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100818111002.GQ6193@shadowen.org>
Date:	Wed, 18 Aug 2010 12:10:02 +0100
From:	Andy Whitcroft <apw@...onical.com>
To:	Rabin VINCENT <rabin.vincent@...ricsson.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Linus WALLEIJ <linus.walleij@...ricsson.com>
Subject: Re: [PATCH] checkpatch: check for incorrect permissions

On Fri, Aug 13, 2010 at 10:25:29AM +0530, Rabin VINCENT wrote:
> On Thu, Aug 12, 2010 at 23:02:22 +0200, Andrew Morton wrote:
> > On Thu, 12 Aug 2010 10:45:45 +0530
> > Rabin Vincent <rabin.vincent@...ricsson.com> wrote:
> > >  		# extract the filename as it passes
> > > -		if ($line=~/^\+\+\+\s+(\S+)/) {
> > > +		if ($line=~/^\+\+\+\s+(\S+)/ || $line=~/^diff\s.*?(\S+)$/) {
> > 
> > Breakage.  This causes the false warning:
> > 
> > WARNING: patch prefix 'drivers' exists, appears to be a -p0 patch
> 
> I've fixed this by matching for the filename in the diff line only when
> it's "diff --git".  Also prevented a double-print of the "do not modify
> file in include/asm" error.
> 
> From b854ea24f1bd5391a63d8d4e2aa63e1c10870816 Mon Sep 17 00:00:00 2001
> From: Rabin Vincent <rabin.vincent@...ricsson.com>
> Date: Wed, 11 Aug 2010 14:45:45 +0530
> Subject: [PATCHv2] checkpatch: check for incorrect permissions

That one looks better.  I've pull this updated one (slightly modified)
into my tree.

Andrew, will send you this shortly.

-apw
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/