linux-kernel - Re: ata_sff_drain

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100818124412.4652eaea@lxorguk.ukuu.org.uk>
Date:	Wed, 18 Aug 2010 12:44:12 +0100
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Pascal GREGIS <pgs@...erway.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: ata_sff_drain_fifo

> so I guess when status is 0xD0, ATA_DRQ is not set but ATA_BUSY is.
> It would explain why in my case it doesn't drain anything before trying to reset.
> 
> Would it be of any interest to drain the fifo also when the ATA_BUSY flag is on, not only the ATA_DRQ ?

If the drive has the busy flag set it is busy, all we can do is wait for
it and if that fails try to reset it. The FIFO drain handles a specific
case where the two ends disagree about the amount of data expected, and
often lets us avoid a reset.

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/