linux-kernel - Re: lockdep false positive? -- firewire-core transaction timer vs. scsi-core host lock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4C6BDA7E.4080203@ladisch.de>
Date:	Wed, 18 Aug 2010 15:05:02 +0200
From:	Clemens Ladisch <clemens@...isch.de>
To:	Stefan Richter <stefanr@...6.in-berlin.de>
CC:	Peter Zijlstra <peterz@...radead.org>,
	Yong Zhang <yong.zhang0@...il.com>,
	Johannes Berg <johannes@...solutions.net>,
	Thomas Gleixner <tglx@...utronix.de>,
	linux1394-devel@...ts.sourceforge.net, linux-kernel@...r.kernel.org
Subject: Re: lockdep false positive? -- firewire-core transaction timer vs.
 scsi-core host lock

Stefan Richter wrote:
> Clemens Ladisch wrote:
> >  	spin_lock_irqsave(&card->lock, flags);
> >  	list_for_each_entry(t, &card->transaction_list, link) {
> >  		if (t == transaction) {
> > +			if (!del_timer(&t->split_timeout_timer))
> > +				goto timed_out;
> 
> +			if (!del_timer(&t->split_timeout_timer)) {
> +				spin_unlock_irqrestore(&card->lock, flags);
> +				goto timed_out;
> +			}

> Shall I commit with the added spin_unlocks?

I can obviously not be trusted to do this correctly; please go ahead.


Regards,
Clemens
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/