linux-kernel - Re: [PATCH] perf tools: Fix build error on read only source.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100818141611.GE9410@ghostprotocols.net>
Date:	Wed, 18 Aug 2010 11:16:11 -0300
From:	Arnaldo Carvalho de Melo <acme@...radead.org>
To:	Peter Zijlstra <peterz@...radead.org>
Cc:	Kusanagi Kouichi <slash@...auone-net.jp>,
	Paul Mackerras <paulus@...ba.org>, Ingo Molnar <mingo@...e.hu>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] perf tools: Fix build error on read only source.

Em Wed, Aug 18, 2010 at 02:40:24PM +0200, Peter Zijlstra escreveu:
> On Wed, 2010-08-18 at 21:37 +0900, Kusanagi Kouichi wrote:
> 
> > With POSIX shell patch, $(OUTPUT) has not been created yet when it is
> > used by try-cc. This fixes the issue anyway.
> > 
> > diff --git a/tools/perf/Makefile b/tools/perf/Makefile
> > index dcb9700..5b1c12b 100644
> > --- a/tools/perf/Makefile
> > +++ b/tools/perf/Makefile
> > @@ -281,6 +281,7 @@ endif
> > 
> >  -include feature-tests.mak
> > 
> > +$(shell mkdir -p $(OUTPUT) 2> /dev/null)
> >  ifeq ($(call try-cc,$(SOURCE_HELLO),-Werror -fstack-protector-all),y)
> >  	CFLAGS := $(CFLAGS) -fstack-protector-all
> >  endif

> So you're wanting to provide a non-existing O=foo ?
> 
> I don't think we should, simply bail when it doesn't exist, kernel
> builds do the same:
> 
> # make O=plop-build bzImage
> /bin/sh: line 0: cd: plop-build: No such file or directory
> Makefile:117: *** output directory "plop-build" does not exist.  Stop.

Agreed that making it work like the kernel brings less surprises, but
isn't it convenient to be able to just do:

rm -rf ~/build
make O=~/build

and have everything work? Saving some keystrokes 8)

- Arnaldo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/