| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Tue, 17 Aug 2010 19:14:24 -0700 (PDT) From: David Miller <davem@...emloft.net> To: torvalds@...ux-foundation.org Cc: akpm@...ux-foundation.org, sparclinux@...r.kernel.org, linux-kernel@...r.kernel.org, paulus@...ibm.com, benh@...nel.crashing.org Subject: Re: [GIT] Sparc From: Linus Torvalds <torvalds@...ux-foundation.org> Date: Tue, 17 Aug 2010 18:59:17 -0700 > In commit 86fa04b8742ac681d470786f55e2403ada0075b2 you fix the return > type, but you still have the wrong _argument_ type: > > extern void atomic64_add(int, atomic64_t *); > extern void atomic64_sub(int, atomic64_t *); > extern long atomic64_add_ret(int, atomic64_t *); > extern long atomic64_sub_ret(int, atomic64_t *); Thanks, I'll fix that up. > I merged your pull request, but you've got some fixing up to do, > methinks. I also really think you need to make your rwsem's use 64-bit > values on sparc64, because otherwise you can overflow the mmap_sem by > having more than 65536 threads doing page-faults (on 32-bit, having > more than 2**16 threads in one process is unlikely to work for other > reasons, like just pure stack usage, so we don't really care about the > 32-bit case) I have a patch to do this already, just need to test it. You should bug the powerpc folks too :-) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists