[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1282168679.6724.174.camel@Joe-Laptop>
Date: Wed, 18 Aug 2010 14:57:59 -0700
From: Joe Perches <joe@...ches.com>
To: Dave Jones <davej@...hat.com>
Cc: apw@...onical.com, Linux Kernel <linux-kernel@...r.kernel.org>
Subject: Re: add memset checks to checkpatch.pl
On Wed, 2010-08-18 at 17:48 -0400, Dave Jones wrote:
> On Wed, Aug 18, 2010 at 02:32:13PM -0700, Joe Perches wrote:
> > On Wed, 2010-08-18 at 16:40 -0400, Dave Jones wrote:
> > > Occasionally someone goofs the argument order to memset.
> > if ($line =~ /\bmemset\s*\(\s*($Lval)\s*,\s*($Lval)\s*,\s*($Lval)\s*\)/) {
> > my $memset_addr = $1;
> > my $memset_val = $2;
> > my $memset_size = $3;
> > if ($memset_size =~ /(0x|)0$/i) {
> > ERROR("memset uses second argument as constant byte value, not third.\n" . $herecurr);
> > elsif ($memset_size =~ /(0x|)1/i) {
> > WARN("single byte memset is suspicious. Swapped 2nd/3rd argument?\n" . $herecurr);
> > }
> > }
> I'm all for improving my shoddy perl where possible, but this doesn't seem to actually
> catch any of the test cases I wrote. (it's also missing a } )
I intend never to be a perl monk.
I notice the missing { before the elsif after I sent it.
Oh well.
I just typed it in the emailer, so it's not tested at all.
Also it's missing a $ after 1 in the second $memset_size test.
What are your test cases anyway?
Likely $Lval isn't matching things like
sizeof(*foo) so this isn't checked:
memset(foo, bar, sizeof(*foo));
Maybe Andy has a better idea?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists