linux-kernel - Re: [RFC PATCH 3/6] perf: Generalize some arch callchain code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100818035109.GC24748@nowhere>
Date:	Wed, 18 Aug 2010 05:51:11 +0200
From:	Frederic Weisbecker <fweisbec@...il.com>
To:	Paul Mackerras <paulus@...ba.org>
Cc:	LKML <linux-kernel@...r.kernel.org>, Ingo Molnar <mingo@...e.hu>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Arnaldo Carvalho de Melo <acme@...hat.com>,
	Stephane Eranian <eranian@...gle.com>,
	David Miller <davem@...emloft.net>,
	Paul Mundt <lethal@...ux-sh.org>,
	Will Deacon <will.deacon@....com>,
	Borislav Petkov <bp@...64.org>
Subject: Re: [RFC PATCH 3/6] perf: Generalize some arch callchain code

On Tue, Aug 17, 2010 at 01:46:34PM +1000, Paul Mackerras wrote:
> On Mon, Aug 16, 2010 at 10:48:32PM +0200, Frederic Weisbecker wrote:
> 
> > - Most archs use one callchain buffer per cpu, except x86 that needs
> >   to deal with NMIs. Provide a default perf_callchain_buffer()
> >   implementation that x86 overrides.
> > 
> > - Centralize all the kernel/user regs handling and invoke new arch
> >   handlers from there: perf_callchain_user() / perf_callchain_kernel()
> >   That avoid all the user_mode(), current->mm checks and so...
> > 
> > - Invert some parameters in perf_callchain_*() helpers: entry to the
> >   left, regs to the right, following the traditional (src, dst).
> 
> I think you mean (dst, src), don't you?


Indeed yeah :)



 
> Apart from that, the patch looks OK, so
> 
> Acked-by: Paul Mackerras <paulus@...ba.org>


Thanks a lot for your reviews and acks!

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/