linux-kernel - number of elements or bytes for kfifo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <1282109365.2744.1549.camel@yhuang-dev>
Date:	Wed, 18 Aug 2010 13:29:25 +0800
From:	Huang Ying <ying.huang@...el.com>
To:	Stefani Seibold <stefani@...bold.net>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: number of elements or bytes for kfifo_in etc

Hi, Stefani,

In new kfifo implementation in 2.6.36-rc1, description of the third
parameter is:

"@n: number of elements to be added"

But if my understanding is correct, the actual implementation is:

"@n: number of bytes to be added"

That is sizeof(*fifo->type) is not considered.

I think we should change either the implementation or the description.

Best Regards,
Huang Ying


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/