linux-kernel - Checkpatch false positive in 2.6.36-rc1.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <5A47E75E594F054BAF48C5E4FC4B92AB0324222271@dbde02.ent.ti.com>
Date:	Wed, 18 Aug 2010 11:34:51 +0530
From:	"Gopinath, Thara" <thara@...com>
To:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:	"apw@...onical.com" <apw@...onical.com>
Subject: Checkpatch false positive in 2.6.36-rc1.

Hello Andy,

The following is my patch.

Index: linux-omap-pm/arch/arm/plat-omap/Kconfig
===================================================================
--- linux-omap-pm.orig/arch/arm/plat-omap/Kconfig
+++ linux-omap-pm/arch/arm/plat-omap/Kconfig
@@ -37,7 +37,7 @@ config OMAP_DEBUG_LEDS

 config OMAP_SMARTREFLEX
        bool "SmartReflex support"
-       depends on ARCH_OMAP3 && PM
+       depends on (ARCH_OMAP3 || ARCH_OMAP4) && PM
        help
          Say Y if you want to enable SmartReflex.


And the following is the check patch error I am getting

WARNING: please write a paragraph that describes the config symbol fully
#108: FILE: arch/arm/plat-omap/Kconfig:41:
        help

total: 0 errors, 1 warnings, 67 lines checked


I think this is a wrong warning as in the first place this is not a line
introduced or removed by my change. Also If I go to the relevant Kconfig
and take a look at this option it appears as below. So this means there
is an actual paragraph following the help.

config OMAP_SMARTREFLEX
        bool "SmartReflex support"
        depends on (ARCH_OMAP3 || ARCH_OMAP4) && PM
        help
          Say Y if you want to enable SmartReflex.

          SmartReflex can perform continuous dynamic voltage
          scaling around the nominal operating point voltage
          according to silicon characteristics and operating
          conditions. Enabling SmartReflex reduces power
          consumption.

          Please note, that by default SmartReflex is only
          initialized. To enable the automatic voltage
          compensation for VDD1 and VDD2, user must write 1 to
          /debug/pm_debug/Smartreflex/SR<X>/autocomp,
          where X is 1 or 2 for OMAP3


Regards
Thara
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/