linux-kernel - RE: [PATCH] power_supply: add isp1704 charger detection driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5A47E75E594F054BAF48C5E4FC4B92AB032422290C@dbde02.ent.ti.com>
Date:	Thu, 19 Aug 2010 16:29:05 +0530
From:	"Gadiyar, Anand" <gadiyar@...com>
To:	"Krogerus Heikki (EXT-Teleca/Helsinki)" 
	<ext-heikki.krogerus@...ia.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
CC:	"linux-omap@...r.kernel.org" <linux-omap@...r.kernel.org>,
	"dwmw2@...radead.org" <dwmw2@...radead.org>,
	"cbou@...l.ru" <cbou@...l.ru>,
	"felipe.balbi@...ia.com" <felipe.balbi@...ia.com>,
	"ameya.palande@...ia.com" <ameya.palande@...ia.com>,
	"markus.lehtonen@...ia.com" <markus.lehtonen@...ia.com>,
	"roger.quadros@...ia.com" <roger.quadros@...ia.com>
Subject: RE: [PATCH] power_supply: add isp1704 charger detection driver

> +static void isp1704_charger_work(struct work_struct *data)
> +{
> +	struct isp1704_charger	*isp =
> +		container_of(data, struct isp1704_charger, work);
> +
> +	/* FIXME Only supporting dedicated chargers even though isp1704 can
> +	 * detect HUB and HOST chargers. If the device has already been
> +	 * enumerated, the detection will break the connection.
> +	 */

Minor CodingStyle comment (since you're reworking the patch anyway).

Preferred style for multi-line comments is:

/*
 * FIXME Only supporting ...
 * detect HUB ...
 * enumerated ...
 */

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/