linux-kernel - Re: Regarding USB-Serial Device driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100819141812.GA12375@suse.de>
Date:	Thu, 19 Aug 2010 07:18:12 -0700
From:	Greg KH <gregkh@...e.de>
To:	Marek Vasut <marek.vasut@...il.com>
Cc:	Raju Rameshwar Uprade <rajsingh@...a.tifr.res.in>,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org,
	maxinbjohn@...il.com, orest.bond@...postembedded.com,
	vijaykumar@...ogic.com
Subject: Re: Regarding USB-Serial Device driver

On Thu, Aug 19, 2010 at 09:38:44AM +0200, Marek Vasut wrote:
> Dne ??t 19. srpna 2010 08:17:30 Raju Rameshwar Uprade napsal(a):
> > Dear Sir,
> >          I am trying to write a Pl2303_mcm.c usb-serial device driver which
> > will be able to talk to several devices using RS-485 interface card.I have
> > modified the standard pl2303.c by which I am able to enable/disable the
> > RTS line.
> > I am sending 10 bytes of data to the device, data is going out but instead
> > of 10 bytes, device driver is sending a large amount of data as seen on
> > Lecroy waverunner oscilloscope. Here I am sending the modified file.
> 
> Hi, I have no idea why I'm CCed in this, but anyway.
> 
> 1) could you please update the driver to a more recent kernel (we are 10 kernel 
> versions further now)
> 2) could you please send a diff instead of a whole file? (git diff <file1> 
> <file2> > diff.diff ... see man git-diff)

Yes, Raju, please see the file, Documentation/SubmittingPatches for how
to do this properly.

Also, does your updated driver work properly for you?  It would be good
to have proper RTS support in the pl2303 driver, but I thought that the
driver already supported this?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/