linux-kernel - Re: [MeeGo-Dev][PATCH] Topcliff: Update PCH

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100819151712.GC2562@suse.de>
Date:	Thu, 19 Aug 2010 08:17:12 -0700
From:	Greg KH <gregkh@...e.de>
To:	Masayuki Ohtake <masa-korg@....okisemi.com>
Cc:	meego-dev@...go.com, LKML <linux-kernel@...r.kernel.org>,
	yong.y.wang@...el.com, qi.wang@...el.com,
	andrew.chih.howe.khor@...el.com, arjan@...ux.intel.com,
	alan@...ux.intel.com, margie.foster@...el.com
Subject: Re: [MeeGo-Dev][PATCH] Topcliff: Update PCH_PHUB driver to 2.6.35

On Thu, Aug 19, 2010 at 03:27:23PM +0900, Masayuki Ohtake wrote:
> Hi Greg,
> 
> Thank you for your comments.
> > > +#define MODULE_NAME "pch_phub"
> >
> > This isn't needed, right?  The kernel provides this to you in the build
> > service automatically.
> 
> I can't understand above enough.
> Is the above mean  like below ?
> 
> * Delete the following line.
> > > +#define MODULE_NAME "pch_phub"
> 
>  * Modify the following line(Use "pch_phub" directly)
> > > + ret = pci_request_regions(pdev, "pch_phub");

No, use the variable that the build system provides to you,
KBUILD_MODNAME

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/