linux-kernel - Re: [RFC v3] ext4: Combine barrier requests coming from fsync

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4C6D5257.9040305@kernel.org>
Date:	Thu, 19 Aug 2010 17:48:39 +0200
From:	Tejun Heo <tj@...nel.org>
To:	Christoph Hellwig <hch@...radead.org>
CC:	"Darrick J. Wong" <djwong@...ibm.com>, "Ted Ts'o" <tytso@....edu>,
	Mingming Cao <cmm@...ibm.com>,
	Ric Wheeler <rwheeler@...hat.com>,
	linux-ext4 <linux-ext4@...r.kernel.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	Keith Mannthey <kmannth@...ibm.com>,
	Mingming Cao <mcao@...ibm.com>
Subject: Re: [RFC v3] ext4: Combine barrier requests coming from fsync

Hello, again.

On 08/19/2010 11:17 AM, Tejun Heo wrote:
> What was the configuration?  If dm was involved, both md and dm can
> only process single flush request at a time.  Supporing multiple
> flushes in flight wouldn't be too difficult.  It's just the way things
> are implemented with the previous barrier implementation.  It can
> definitely be improved.

Oh, I just realized that the current bio-based dm implementation
doesn't allow other bio's to be processed if a flush is in progress.
So, it's not about not being able to handle multiple flushes.  The
queue just stalls while flush is in progress and because it also waits
for flush completion by waiting for all commands in progress to
finish.  It basically ends up draining and stalling everything.
Shouldn't be too hard to make it better.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/